Skip to content

Remove invalid HTMLImageElement.create #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2019
Merged

Remove invalid HTMLImageElement.create #366

merged 1 commit into from
May 14, 2019

Conversation

exoego
Copy link
Contributor

@exoego exoego commented May 14, 2019

Closes #274

sjrd
sjrd requested changes May 14, 2019
View reviewed changes
Copy link
Member

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest going as far as removing it entirely, since it obviously does not work whatsoever.

@exoego
Copy link
Contributor Author

exoego commented May 14, 2019

Removed entirely in 7abdf75

@exoego exoego changed the title HTMLImageElement.create is not defined in any standard. Remove invalid HTMLImageElement.create May 14, 2019
@sjrd sjrd merged commit deffe6c into scala-js:master May 14, 2019
@exoego exoego deleted the image-create branch May 14, 2019 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd sjrd sjrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HTMLImageElement's create() is probably wrong
2 participants
@exoego @sjrd